Which takes up more space - one cup of liquid water or one cup of ice?

Liquid water would typically take up more space because as ice expands, air pockets are generated. Water takes up the entirety of the space of whatever container it is in.