You have an 88-90 jetta carat it has a rough idle and makes a tapping sound and after it runs for a while it starts to smoke out of the motor any help?

Check your oil level or change your oil and filter.

This sounds like worn-out piston rings. Have a mechanic do a compression test and cylinder leak-down test to confirm before, spending money to replace or rebuild the engine.