yes he will die in onepiece but not yet
Bruce Shanks died in 1980.
Emily Shanks died in 1936.
William Shanks died in 1882.
Oliver Shanks died in 1970.
Edward Shanks died in 1953.
Shanks loses his arm while saving a young Luffy from a Sea King. Luffy had just previously been abducted by a group of bandits, the leader of whom had taken Luffy out to sea and had been subsequently eaten by the same Sea King.
Charles G. Shanks died in 1895.
Simon Shanks died on 2006-01-05.
Daniel Shanks died on 1996-09-06.
James Steuart Shanks died in 1911.
Howie Shanks died on 1941-07-30.
I think he will. He may die in the grandline. but he will be really close.