What phone is better the iPhone 3GS or iPhone 4?

It really depends on your preferences. The iPhone 4 might have some more improvements but they are really similar.