Who wrote the story of a magic cupboard which would give you what ever you wished for so long as you put something inside and it stopped working when nothing was put in and a wish was made?

Answer 1

This sounds a lot like The Indian in the Cupboard by British author Lynne Reid Banks.

Answer 2

The story you are referring to is "The Indian in the Cupboard" by Lynne Reid Banks. In the story, a boy named Omri discovers that a magical cupboard can bring small plastic toys to life when they are placed inside, but they revert back when taken out. The story explores themes of friendship, responsibility, and the consequences of using magic for personal gain.