Why did Spain and Portugal become rivals?

Answer 1

The rivalry (in the 16th century) concerned the issue of which country could claim and exploit which part of the newly discovered Americas and other parts of the world newly discovered or yet to be discovered.

The issue was settled by mutual consent by the Pope, who divided the map of the world in a Spanish and a Portuguese sphere of influence and colonization, where the other party had to stay out of.