Is broken colored glass good luck?

Broken anything is not usually lucky. There are several charms of protection I know of that use broken glass as part of the spell, and re-cut pieces of coloured glass can be cleansed and used in magical charms or decorative stained glass pieces.