Benedict Arnold is a hero or traitor?

Answer 1

Both, but most people remember him as a hero, because he helped win victory against the British. He was a traitor because he thought people don't respect him, so he joined the British also because he made a deal. Benidict didn't get what he wanted from the British, which was money, so he died poor.

Answer 2

First one, then the other. Which depends on which side you were on. From the point of view of the rebellious colonists, he was first a hero then a traitor; from the point of view of the British Empire, it was somewhat the other way around.